Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate with jupyterlab-github #6

Open
ian-r-rose opened this issue Aug 2, 2019 · 1 comment
Open

Integrate with jupyterlab-github #6

ian-r-rose opened this issue Aug 2, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@ian-r-rose
Copy link
Member

I think there are some opportunities here to integrate this with @jupyterlab/github and have a more unified experience for users. I haven't really thought it all through, but some ideas could involve:

  1. Opening the branch-in-question in the GitHub filebrowser for looking at the un-diffed files.
  2. Unified handling of API tokens on the server side.
  3. Launch @jupyterlab/pull-requests from the GitHub filebrowser.
@jaipreet-s
Copy link
Member

Thanks @ian-r-rose . I agree with all of these.

Launch @jupyterlab/pull-requests from the GitHub filebrowser.

I've been thinking of how to do this for other extensions as well. What's the recommended way for an extension to trigger the some functionality in another extension?

@jaipreet-s jaipreet-s added the enhancement New feature or request label Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ian-r-rose @jaipreet-s