Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move flaky tests to a separate workflow on CI #9677

Merged
merged 5 commits into from
Feb 17, 2021

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Jan 26, 2021

References

The long term motivation is to be able to reach a full green CI some time soon.

For now, this change moves some of the known flaky tests to their own workflow, so they can easily be restarted without re-running everything else. The current list includes:

  • js-services
  • js-apputils

image

Code changes

CI

User-facing changes

None

Backwards-incompatible changes

None

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@jtpio
Copy link
Member Author

jtpio commented Jan 26, 2021

The js-services tests also seem to be timing out locally, so hopefully it should be possible to fix them.

@jtpio
Copy link
Member Author

jtpio commented Jan 27, 2021

The js-services tests also seem to be timing out locally, so hopefully it should be possible to fix them.

This seems to be reproducible locally when running the ikernel.spec.ts tests:

jlpm run test test/kernel/ikernel.spec.ts 

@jtpio
Copy link
Member Author

jtpio commented Jan 27, 2021

It looks like js-services tests might have started timing out in #9484

image

While they were still passing in the previous PR #9483

image

Locally, some hints that it might be related to timeouts on kernel restarts:

image

@jtpio
Copy link
Member Author

jtpio commented Jan 27, 2021

Testing without ikernel.spec.ts locally seems to pass:

image

It looks like the issue is with the restart and shutdown logic.

@jtpio
Copy link
Member Author

jtpio commented Feb 16, 2021

Looks like the services tests are fixed by #9806.

Rebasing to only keep js-apputils in the flaky group for now.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 0d78f6a into jupyterlab:master Feb 17, 2021
@blink1073 blink1073 added this to the 3.1 milestone Feb 17, 2021
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Jan 18, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintenance pkg:services status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants