Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce size of text file editor syntax highlight option list, let users customize it #14420

Open
JasonWeill opened this issue Apr 23, 2023 · 7 comments

Comments

@JasonWeill
Copy link
Contributor

JasonWeill commented Apr 23, 2023

Problem

The "Text Editor Syntax Highlighting" option in the View menu has dozens of languages listed, including one that has been misspelled (#14418) and one that includes an English-language profanity (#14373). More popular languages are hard to find.

Proposed Solution

By default, show a curated list of popular languages (e.g., those used by more than X% of developers in a popular survey) in the syntax highlighting menu. Allow users to customize this list in the settings editor.

@JasonWeill JasonWeill added enhancement status:Needs Triage Applied to new issues that need triage labels Apr 23, 2023
@krassowski
Copy link
Member

What do you think about having a nested submenu:

  • Popular language 1
  • Popular language 2
  • ...
  • Popular language 15
  • More → [opens submenu or maybe a dialog with a full list]

Where popular languages list can be customised in settings as you propose.

@JasonWeill
Copy link
Contributor Author

Even 15 options would be a lot in a cascading submenu, especially if the user is on a small screen or has their zoom setting turned way up. I would avoid having a subsubmenu for accessibility and usability reasons.

Perhaps a simple modal dialog with a dropdown or combo box control (supporting typeahead or inline search) would be better for this.

@krassowski
Copy link
Member

Maybe we could use top 10 most recently used languages, and fall back to a hard-coded "popularity" based list if there is less than 10?

@krassowski
Copy link
Member

Perhaps a simple modal dialog with a dropdown or combo box control (supporting typeahead or inline search) would be better for this.

This is what the statusbar item does.

@krassowski
Copy link
Member

Even 15 options would be a lot in a cascading submenu, especially if the user is on a small screen or has their zoom setting turned way up. I would avoid having a subsubmenu for accessibility and usability reasons.

So 10 options + 11th opens a dialog with full list + search box?

@JasonWeill
Copy link
Contributor Author

I like that: a top 10 list, plus an option to open a dialog with more options.

@JasonWeill
Copy link
Contributor Author

See also #2484

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants