Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JupyterLab Dark theme galata snapshots to (at least) Documentation/debugger, documentation/general, jupyterlab/collapsible-headings, jupyterlab/debugger, jupyterlab/texteditor #14331

Open
andrii-i opened this issue Apr 5, 2023 · 0 comments
Open

Add JupyterLab Dark theme galata snapshots to (at least) Documentation/debugger, documentation/general, jupyterlab/collapsible-headings, jupyterlab/debugger, jupyterlab/texteditor #14331

andrii-i opened this issue Apr 5, 2023 · 0 comments
Labels
bug tag:Accessibility tag:CSS For general CSS related issues and pecadilloes tag:Testing

Comments

@andrii-i
Copy link
Contributor

andrii-i commented Apr 5, 2023

Description

Documentation/debugger, documentation/general, jupyterlab/collapsible-headings, jupyterlab/debugger, jupyterlab/texteditor don't have JupyterLab Dark galata snapshot tests to make sure there are no regressions in regards to changes from #14269 that ensures sufficient text contrast level of code line numbers.

It could be useful to add a snapshot test using dark mode to avoid regressions (could be a follow-up PR).

Originally posted by @krassowski in #14269 (review)

Reproduce

Note absence of JupyterLab Dark galata snapshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug tag:Accessibility tag:CSS For general CSS related issues and pecadilloes tag:Testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andrii-i @JasonWeill