Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Publish to npm #17

Closed
gnestor opened this issue Jul 31, 2018 · 10 comments
Closed

Publish to npm #17

gnestor opened this issue Jul 31, 2018 · 10 comments

Comments

@gnestor
Copy link
Contributor

gnestor commented Jul 31, 2018

Is it time to publish this extension to npm?

@jasongrout
Copy link
Contributor

Yes. Do you feel comfortable doing so? Do you want permissions to do so?

@gnestor
Copy link
Contributor Author

gnestor commented Jul 31, 2018

Sure. I think I might because I have access to the jupyterlab org on npm. Do we want to publish as jupyterlab-monaco or @jupyterlab/monaco, or @jupyterlab/monaco-extension?

@jasongrout
Copy link
Contributor

jasongrout commented Jul 31, 2018

Oh right, I forgot we never published this (I thought you were asking about updating...). It's still, of course, very experimental, but on the other hand, some people have appreciated having it.

Let me take a look at what I think would be a good first cut of features before we initially publish this.

@gnestor
Copy link
Contributor Author

gnestor commented Jul 31, 2018

I agree that it's a great extension, I've been using it in lieu of the default file editor. I will help with future development, publishing, etc. 👍

@nabriis
Copy link

nabriis commented Sep 5, 2018

Is it getting published?

@gnestor
Copy link
Contributor Author

gnestor commented Sep 14, 2018

I just reviewed the open issues on this repo and it looks like there are some jupyterlab monaco extensions for other jupyterlab-based apps that offer LSP integration and monaco in notebook code cells, so maybe we should wait to add these features before publishing this package? Or we can just publish now that it's stable...

@TiemenSch
Copy link

I'd say that it would help to get some traction just by publishing what there already is!

@dhirschfeld
Copy link
Member

Maybe merge #22 (if it's ready to go now) then publish?

@fcollonval
Copy link
Member

@dhirschfeld I'ld love to get my PR merged. But there is a packaging issue due to monaco-languageclient 0.9.0. A alias for a simplified vscode package should be passed to webpack. For building the extension it is easy. But for jupyterlab I don't know how to do it with out touching the standard webpack.config shipped with jupyterlab.
Maybe @gnestor or @jasongrout have some ideas?

@gnestor
Copy link
Contributor Author

gnestor commented Nov 15, 2018

@fcollonval Excellent work on #22!! I don't fully understand your packaging issue. Can you give me an idea of what webpack config would need to change?

One way around webpack issues in general is to append scripts to the DOM. I have done this in other projects to get monaco editor working when webpack isn't exactly configurable. Not sure if this relevant to you issue...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants