Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for jupyterlab 3 #779

Closed
ianhi opened this issue Sep 21, 2020 · 24 comments · Fixed by #818
Closed

Update for jupyterlab 3 #779

ianhi opened this issue Sep 21, 2020 · 24 comments · Fixed by #818

Comments

@ianhi
Copy link
Collaborator

ianhi commented Sep 21, 2020

edit - Install jupyterlab-git beta: Jupyterlab-git has a beta release which you can install with:

pip install --upgrade --pre jupyterlab-git

Description

Jupyterlab version 3 is nearly upon us (rc this week I think?).
The update to jlab3 may be as simple as running: python -m jupyterlab.upgrade_extension . but what should be done w.r.t branches on this repo? Should master track jlab 3 and then create a 0.2x.y branch for bugfixes for jlab2?

@fcollonval
Copy link
Member

Yes the master should follow the latest major JupyterLab. And for older JupyterLab, the branches 0.#x.y works fine.

We should also think what is required to reach 1.x => but not in an issue rather linking issue to milestone.

@fcollonval fcollonval added this to the 0.30.0 milestone Sep 22, 2020
@orome
Copy link
Contributor

orome commented Dec 25, 2020

With 3.0 I get The extension "@jupyterlab/git" is outdated.. Does this extension not currently work with 3.0?

@jasongrout
Copy link

With 3.0 I get The extension "@jupyterlab/git" is outdated.. Does this extension not currently work with 3.0?

This issue is not closed, and the corresponding PR (#818) has not been merged, so it's probably reasonable to assume that it hasn't been updated for 3.0 yet?

@fcollonval
Copy link
Member

fcollonval commented Dec 28, 2020

It is not yet release for JupyterLab 3 as it requires first nbdime to be released on it.

If you want to be notified when it will be released, you can subscribe to this issue in the right panel.

@fcollonval fcollonval pinned this issue Dec 28, 2020
@spouyllau
Copy link

Hello,
Have a idea of the disposability on jupyterlab 3 of jupyterlab-git ?
Best,

@GoingMyWay
Copy link

Hello,

When will you support the jupyterlab 3?

Best

@KPouianou
Copy link

Is there any ETA on this? It is a serious limitation for us a we use multiple plugins that require Lab v3

@fcollonval
Copy link
Member

I'm reopening as the current status is beta for JLab3 (waiting for final release of nbdime).

@fcollonval fcollonval reopened this Jan 20, 2021
@fcollonval
Copy link
Member

A beta version has been released for JupyterLab 3. To test it you can install it with:

pip install --pre jupyterlab-git==0.30.0b1

CC @ajbozarth

@hawlcat
Copy link

hawlcat commented Jan 20, 2021

I tried this, and got this:

Capture

Any idea?

@ianhi
Copy link
Collaborator Author

ianhi commented Jan 20, 2021

I think that for jupyterlab 3 the command should be: jupyter server extension list

there's an extra space in serverextension -> server extension

@hawlcat
Copy link

hawlcat commented Jan 22, 2021

Thank you @ianhi

I am using jupyterhub, and have this problem:
image

I checked using jupyter server extension list, and jupyter labextension list to check, looks everything fine.
image

If I run jupyterlab directly on the server, and everything is fine including git operation as I tried.

Anyone has any idea about this issue?

Thank you.

@JessicaBarh
Copy link
Contributor

Thank you @ianhi

I am using jupyterhub, and have this problem:
image

I checked using jupyter server extension list, and jupyter labextension list to check, looks everything fine.
image

If I run jupyterlab directly on the server, and everything is fine including git operation as I tried.

Anyone has any idea about this issue?

Thank you.

Also having this issue. Any suggestions?

@fcollonval
Copy link
Member

With JupyterHub and JupyterLab 3, the setting to start JupyterLab has changed - see the documentation.

To change the user’s default user interface to JupyterLab, set the following configuration option in your jupyterhub_config.py file:

c.Spawner.cmd=["jupyter-labhub"]

@JessicaBarh
Copy link
Contributor

With JupyterHub and JupyterLab 3, the setting to start JupyterLab has changed - see the documentation.

To change the user’s default user interface to JupyterLab, set the following configuration option in your jupyterhub_config.py file:

c.Spawner.cmd=["jupyter-labhub"]

My default user interface is Jupyterlab. Would this have anything to do with nbdime? I'm using the newest beta version 3.0.0.b1

@hawlcat
Copy link

hawlcat commented Jan 22, 2021

@JessicaBarh , FYI, I downgraded jupyterlab to 2.x, and also git. Everything goes back normal.

@krassowski
Copy link
Member

krassowski commented Jan 22, 2021

@JessicaBarh what about this one: https://github.com/krassowski/jupyterlab-lsp/issues/375#issuecomment-761078622

I think predicted it will affect jupyterlab-git users here: jupyterlab/jupyterlab#9616 (comment) ;)

But, seriously now, is there a way we could help JupyterHub to release a version defaulting to jupyter_server sooner? I will open an issue on jupyter-hub repo. Here it is: jupyterhub/jupyterhub#3340

@ajbozarth
Copy link
Member

What's the timeline on releasing 0.30.0 with the lab 3 support?

@fcollonval
Copy link
Member

What's the timeline on releasing 0.30.0 with the lab 3 support?

We need nbdime for JLab3 to get out of beta. I think what is holding nbdime is the broken tests if you want to help with that.

@reallyrandom
Copy link

reallyrandom commented Feb 2, 2021

I am facing the exact same issue as @hawlcat and @JessicaBarh

running jupyterhub and installing in notebook server using:

pip install --pre jupyterlab-git==0.30.0b1

RUN jupyter labextension install @jupyterlab/git

Is there a workaround that doesn't require downgrading?

@JessicaBarh
Copy link
Contributor

@william-sheldon @hawlcat I got it working using jupyter server vs jupyter notebook to start up my image.
You'll also need to rename your jupyter_notebook_config.py file to jupyter_server_config.py and rename all c.NotebookApp traits to c.ServerApp in it. see https://jupyter-server.readthedocs.io/en/latest/operators/migrate-from-nbserver.html for more info

@meeseeksmachine
Copy link

This issue has been mentioned on Jupyter Community Forum. There might be relevant details there:

https://discourse.jupyter.org/t/jupyterlab-git-in-jupyter-hub/8108/2

@stonebig
Copy link

nbdime-3.0.0 is out

@fcollonval fcollonval unpinned this issue Apr 17, 2021
@fcollonval
Copy link
Member

The first version supporting JupyterLab 3 (jupyterlab-git==0.30.0) has been released on pypi.org. conda release will follow soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.