Cancelling a push by clicking away from the dialog incorrectly asks for git credentials

[ianhi]

Description

In the below gif I interact with the push dialog in three different ways

1. Let it finish
   • Works - no issues with credentials
2. Dismiss using the dismiss button
   • Works as expected
3. Cancel the full screen modal by clicking somewhere other than the push dialog
   • This incorrectly brings up the credentials dialog

Reproduce

With setting "blockWhileCommandExecutes": true:

1. Enter a repo you have approriate credentials for
2. click push button
3. click somewhere on the screen
4. Git credentials box pops up

Expected behavior

Credentials box does not pop up

Context

• Python package version: 0.21.0a0

• Extension version: 0.21.0a0

• Git version: 2.25.1

• Operating System and its version: PopOs 20.04

No interesting output in either console

[fcollonval]

@ianhi Thank for testing the extension. I'm working on this one as part of #721

[ianhi]

If I just click ok on the credentials dialog then the push will complete:

but clicking multiple times will continue to spawn the box:

[ianhi]

From #721 (comment) this is not an issue with the new modal. It is partially and issue with jupyterlab dialogs and partially with how the push dialog handles cancelling of the dialog.