We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When working on jupyterlab repo if I start jupyterlab from packages sub-directory and try to open a modified file from the git sidebar it shows:
packages
Uncaught (in promise) Error: No such file or directory: packages/completer/style/base.css
The path here is wrong: it starts at the git root, but it should be relative to jupyterlab root.
@jupyterlab/git v0.41.0 enabled OK (python, jupyterlab-git)
The text was updated successfully, but these errors were encountered:
That case is really tricky. I think the only correct behavior we should accept is denying the folder as being a git repository.
The reason is that otherwise we do not respect the security rule of not accessing files upper than the server root directory.
Sorry, something went wrong.
Successfully merging a pull request may close this issue.
Description
When working on jupyterlab repo if I start jupyterlab from
packages
sub-directory and try to open a modified file from the git sidebar it shows:The path here is wrong: it starts at the git root, but it should be relative to jupyterlab root.
Context
@jupyterlab/git v0.41.0 enabled OK (python, jupyterlab-git)
The text was updated successfully, but these errors were encountered: