Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files do not open from side panel if lab started from subdirectory of git #1205

Closed
krassowski opened this issue Dec 24, 2022 · 1 comment · Fixed by #1278
Closed

Files do not open from side panel if lab started from subdirectory of git #1205

krassowski opened this issue Dec 24, 2022 · 1 comment · Fixed by #1278
Labels

Comments

@krassowski
Copy link
Member

krassowski commented Dec 24, 2022

Description

When working on jupyterlab repo if I start jupyterlab from packages sub-directory and try to open a modified file from the git sidebar it shows:

Uncaught (in promise) Error: No such file or directory: packages/completer/style/base.css

The path here is wrong: it starts at the git root, but it should be relative to jupyterlab root.

Context

  • Python package version: 0.41.0
  • Extension version: @jupyterlab/git v0.41.0 enabled OK (python, jupyterlab-git)
  • Git version: 2.37.2
  • Operating System and its version: Ubuntu, latest
@krassowski krassowski added the bug label Dec 24, 2022
@fcollonval
Copy link
Member

That case is really tricky. I think the only correct behavior we should accept is denying the folder as being a git repository.

The reason is that otherwise we do not respect the security rule of not accessing files upper than the server root directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants