Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File save hooks don't seem to work in JLDA #589

Closed
miwojc opened this issue Feb 21, 2023 · 3 comments
Closed

File save hooks don't seem to work in JLDA #589

miwojc opened this issue Feb 21, 2023 · 3 comments

Comments

@miwojc
Copy link

miwojc commented Feb 21, 2023

It seems Jupyter Desktop App doesn't use File Save hooks, which work for Jupyter Lab.
https://jupyter-server.readthedocs.io/en/latest/developers/savehooks.html

JLDA version: 3.6.1-1 (hooks don't work)

JL version: Version 3.4.8 (hooks work)

Update. When connected to existing JL server then they work in JLDA. So it must be different location expected for the hooks for the JLDA. Currently my hooks are in ~/.jupyter. Which directory this should be for the JLDA?

@welcome
Copy link

welcome bot commented Feb 21, 2023

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@miwojc miwojc changed the title https://jupyter-server.readthedocs.io/en/latest/developers/savehooks.html File save hooks don't seem to work in JLDA Feb 21, 2023
@mbektas
Copy link
Member

mbektas commented Feb 21, 2023

@miwojc currently jupyter config files are disabled for the desktop app, but with this PR I am adding ability to specify additional launch arguments, so you will be able to specify a config file ('--JupyterApp.config_file).

@JasonWeill
Copy link

PR #588 is merged, so it seems like this bug is now fixed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants