Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend does not work unless jupyterlab-collaboration-ui is installed #330

Closed
krassowski opened this issue Jul 18, 2024 · 4 comments · Fixed by #331
Closed

Frontend does not work unless jupyterlab-collaboration-ui is installed #330

krassowski opened this issue Jul 18, 2024 · 4 comments · Fixed by #331
Labels
bug Something isn't working

Comments

@krassowski
Copy link
Member

Description

Installing jupyter-server-ydoc and jupyter-docprovider in the latest beta version breaks jupyterlab. Installing jupyterlab-collaboration-ui fixes it:

image

@krassowski krassowski added the bug Something isn't working label Jul 18, 2024
@krassowski
Copy link
Member Author

It looks like this is due to #287 which introduced a bad dependency on @jupyter/collaboration in docprovider; docprovider cannot depend on the collaboration UI. CC @brichet.

@brichet
Copy link
Contributor

brichet commented Jul 19, 2024

@krassowski the only need for this dependency is for this token.
Do you think that it make sense to move it to another package ?

I'm not clear about the packaging of this repo. For instance the package collaboration depends on docprovider but doesn't seem to use it:

"@jupyter/docprovider": "^3.0.0-beta.0",

And also I can reproduce the other errors you shared, about some missing dependencies of @jupyterlab packages....

@krassowski
Copy link
Member Author

Thank you for looking into it!

Do you think that it make sense to move it to another package ?

Yes, let's move it.

I'm not clear about the packaging of this repo. For instance the package collaboration depends on docprovider but doesn't seem to use it:

It was there before the refactor too. I guess we could remove it.

And also I can reproduce the other errors you shared, about some missing dependencies of @jupyterlab packages....

By default you would only see the first two errors (error and a warning). If https://github.com/datalayer/jupyter-server-nbmodel is installed the additional error will also show up, because this issue also prevents it from starting.

@brichet
Copy link
Contributor

brichet commented Jul 19, 2024

Thanks @krassowski, I'm opening a PR to fix it, moving the IGlobalAwareness token to the docprovider package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants