Chats directory config #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jtpio
reviewed
Oct 25, 2024
| "defaultDirectory": { | ||
| "description": "Default directory where to create and look for chat.", | ||
| "type": "string", | ||
| "default": "", |
There was a problem hiding this comment.
Should the setting provide more information (for example via the description) on where files are saved by default? Since an empty string can be ambiguous?
|
btw, maybe we could add a note to the README and / or the changelog that Thinking about it since this PR changes a few parameters, function signatures, typings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #61
Allow the user to configure the default directory for chat creation and list (in side panel).
Note
This is a suggestion if we wish to continue listing chat files in a single directory in the side panel.
We could also think of a way to manage chat files in the whole tree file: