Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting sections are slightly confusing when empty #903

Closed
krassowski opened this issue Jul 18, 2024 · 0 comments · Fixed by #918
Closed

Setting sections are slightly confusing when empty #903

krassowski opened this issue Jul 18, 2024 · 0 comments · Fixed by #918
Labels
bug Something isn't working

Comments

@krassowski
Copy link
Member

Description

Specific settings sections (Language model, Embedding model, Inline completions model, API Keys) may be empty if:

  • the operator disabled all models of given type
  • user has no API keys configured and selected model does not require any

This leads to a rather confusing display of empty sections because user may expect to be able to make a choice or see an imput for API keys, but is presented with an empty dropdown or API keys empty section without any explanation.

image

Reproduce

  1. jupyter lab --AiExtension.allowed_providers=''
  2. Open chat settings

Expected behavior

  1. The API keys section is either hidden or shows "No API keys needed for the selected models" placeholder
  2. The model sections are hidden if no relevant model is found, or instead of a dropdown list show a placeholder like "No embedding models are configured by the system administrator" (wording to be improved) to highlight that this is not a user error and user has nothing to do other than contact the operator of the Jupyter instance if they really want such a model.

Context

2.19.0

@krassowski krassowski added the bug Something isn't working label Jul 18, 2024
@dlqqq dlqqq closed this as completed in #918 Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant