Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-index learned directories when embedding provider changes #133

Closed
3coins opened this issue May 1, 2023 · 1 comment · Fixed by #137
Closed

Re-index learned directories when embedding provider changes #133

3coins opened this issue May 1, 2023 · 1 comment · Fixed by #137
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@3coins
Copy link
Collaborator

3coins commented May 1, 2023

Problem

When embedding provider is updated, existing vector store index does not work because of the embeddings mismatch. This causes an assertion error when /ask command is used and require users to manually delete the index with the /learn -d command.

Solution

  1. When the embedding provider changes, indicate to the user that doing so will cause issues with the existing index, and the existing index will be deleted.
  2. Prompt the user if they want to still go ahead and they also want to index all the directories they have indexed before.
  3. Update the backend to delete the existing index, and re-index all the directories that have been learned before.
@3coins 3coins added the enhancement New feature or request label May 1, 2023
@3coins 3coins self-assigned this May 2, 2023
@3coins 3coins added this to the 0.8.0 Release milestone May 2, 2023
@3coins
Copy link
Collaborator Author

3coins commented May 9, 2023

Completed with #137

@3coins 3coins closed this as completed May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant