Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change npm-run-all to npm-run-all2 #91

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Change npm-run-all to npm-run-all2 #91

merged 1 commit into from
Nov 21, 2024

Conversation

joaopalmeiro
Copy link
Contributor

@joaopalmeiro joaopalmeiro commented Nov 14, 2024 •
edited
Loading

Closes #76

Hi! 👋

I changed npm-run-all to npm-run-all2 considering the latest version (which supports at least Node.js 18). What do you think? Thanks!

fcollonval
fcollonval approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @joaopalmeiro

@fcollonval
Copy link
Member

CI failure are not related.

@fcollonval fcollonval merged commit 1de66a0 into jupyterlab:main Nov 21, 2024
21 of 24 checks passed
@joaopalmeiro joaopalmeiro deleted the change-to-npm-run-all2 branch November 21, 2024 15:23
@joaopalmeiro joaopalmeiro self-assigned this Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcollonval fcollonval fcollonval approved these changes

Assignees

@joaopalmeiro joaopalmeiro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change npm-run-all to npm-run-all2
2 participants
@joaopalmeiro @fcollonval