Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inclusion of react-addons-linked-state-mixin in package.json breaks compilation #82

Open
krassowski opened this issue Jul 10, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@krassowski
Copy link
Member

When "@rjsf/core": "5.18.3" or newer is installed the compilation on jupyterlab/jupyterlab_apod#20 fails:

node_modules/@rjsf/core/lib/components/Form.d.ts:292:76 - error TS2694: Namespace '"/node_modules/@types/react/jsx-runtime"' has no exported member 'JSX'.

292     renderErrors(registry: Registry<T, S, F>): import("react/jsx-runtime").JSX.Element | null;
                                                                               ~~~

node_modules/@rjsf/core/lib/components/Form.d.ts:367:43 - error TS2694: Namespace '"/node_modules/@types/react/jsx-runtime"' has no exported member 'JSX'.

367     render(): import("react/jsx-runtime").JSX.Element;
                                              ~~~

downgrading to 5.18.2 fixes the issue.

react-addons-linked-state-mixin was added in #38. Why is it needed?

@krassowski krassowski added the bug Something isn't working label Jul 10, 2024
@krassowski
Copy link
Member Author

Of note, deduplication does not fix it. It looks like a more fundamental resolution error. So there are three solutions for the users:

  • add resolutions: {"@rjsf/core": "5.18.2"} in package.json
  • remove react-addons-linked-state-mixin from package.json
  • set skipLibCheck: true

@krassowski
Copy link
Member Author

Nah, I think I was wrong about this. Back to debugging.

@krassowski
Copy link
Member Author

No, actually both resolutions need to be set and react-addons-linked-state-mixin removed from dependencies to make jupyterlab/jupyterlab_apod#20 pass. I think we need to change something so that extension tutorial can be followed without need for this but I have not attempted to reproduce this yet

@krassowski krassowski reopened this Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant