Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the dictionaries into separate modules #77

Open
krassowski opened this issue Jun 1, 2021 · 1 comment
Open

Move the dictionaries into separate modules #77

krassowski opened this issue Jun 1, 2021 · 1 comment

Comments

@krassowski
Copy link
Collaborator

We may want to move the existing dictionaries (especially the heavier ones) into separate sub-packages e.g. jupyterlab-spellchecker-de_AT (each German dictionary weighs 4.4 MB). After #74 this becomes trivial as we only need to place the dictionary in the jupyter/dictionaries directory. We should create a helper function in jupyterlab-spellchecker that will use jupyter_packaging to place the dictionary where needed and import that function in setup.py (which will be the only file except for dictionaries) of the sub-packages.

Finally we could also create alias packages e.g. jupyterlab-spellchecker-german collecting:

  • jupyterlab-spellchecker-de_AT,
  • jupyterlab-spellchecker-de_CH, and
  • jupyterlab-spellchecker-de_DE.
@krassowski
Copy link
Collaborator Author

krassowski commented Jun 1, 2021

Note: language packs seem be to using hyphen rather than an underscore - let's coordinate for consistent user experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant