Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.8.3 is JupyterLab 4.x only #135

Closed
jhgoebbert opened this issue Jul 9, 2023 · 5 comments · Fixed by #138
Closed

0.8.3 is JupyterLab 4.x only #135

jhgoebbert opened this issue Jul 9, 2023 · 5 comments · Fixed by #138
Labels
bug Something isn't working

Comments

@jhgoebbert
Copy link

You might want to set the requirement for 0.8.3 to JupyterLab>=4 as @codemirror/language doesn't in JupyterLab 3.x
At lease I see this error in the WebConsole:
Error: Shared module @codemirror/language doesn't exist in shared scope default
https://github.com/jupyterlab-contrib/spellchecker/blob/master/src/index.ts#L5

@jhgoebbert jhgoebbert added the bug Something isn't working label Jul 9, 2023
@krassowski
Copy link
Collaborator

Yes, 0.8.x requires JupyterLab 4 or Notebook 7. I am not sure how to specify dependency in that case; I do not want to add jupyterlab>=4 because notebook users do not necessarily want to install jupyterlab with this extension. Any suggestions?

@jhgoebbert
Copy link
Author

Ah, I see 🤔 . That is tricky.

@krassowski
Copy link
Collaborator

Actually we can just pin jupyterlab since notebook 7 depends on jupyterlab. #138 does that.

@krassowski
Copy link
Collaborator

@jhgoebbert a new release (v0.8.4) with a pin is up on PyPI, can you confirm whether installation resolves correctly for you (or whether we need to yank the older versions)?

@jhgoebbert
Copy link
Author

Hi @krassowski
yes, I installed spellchecker==0.8.4 with JupyterLab 4.0 (from source and wheel). It works perfect and I cannot see any issues at install or runtime.
I also tried to install it with JupyterLab 3.6 using notebook 6 - now the installation failed as expected. That is much better than 0.8.3 which installs fine but fails at runtime. Yes, perhaps you really want to yank 0.8.3. That would help the users who try to install it as extension for JupyterLab 3.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants