Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupyter 4 compatibility #29

Closed
cameronrutherford opened this issue Jun 5, 2023 · 2 comments
Closed

Jupyter 4 compatibility #29

cameronrutherford opened this issue Jun 5, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@cameronrutherford
Copy link

cameronrutherford commented Jun 5, 2023

Description

JupyterLab 4.0 came out recently and I wanted to use this with extensions like jupyter_collaboration, jupyterlab-quatro.

There is a migration guide https://jupyterlab.readthedocs.io/en/latest/extension/extension_migration.html#jupyterlab-3-x-to-4-x to update.

Unfortunately, quatro doesn't seem to support interactive presentations in the way rise does, so I would love this to be updated.

Reproduce

I personally am using Apptainer on an HPC cluster, but a min reproducer is just installing the following container.

Dockerfile

FROM jupyter/minimal-notebook

RUN pip install --upgrade pip

RUN pip jupyter_collaboration \
                jupyterlab_rise

Expected behavior

I haven't attempted to update, but I imagine the first step is changing the pyproject.toml version https://github.com/jupyterlab-contrib/rise/blob/main/pyproject.toml#L2, and then figuring out what breaking API changes might have been made.

@cameronrutherford cameronrutherford added the bug Something isn't working label Jun 5, 2023
@cameronrutherford cameronrutherford changed the title Jupyter 4.0+ compatibility Jupyter 4 compatibility Jun 5, 2023
@nthiery
Copy link
Contributor

nthiery commented Sep 1, 2023

I am currently testing jupyterlab-rise with jupyterlab 4.0, and it seems
to work smoothly (up to other issues already present with jupyterlab 3).

Presumably this was fixed by #39 and #42.

Does it work in your setting? If yes, maybe this issue can be closed.

@fcollonval
Copy link
Member

Closing it is supported starting with version 0.40.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants