emit FileBrowserModel.pathChanged signal #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Bot please update playwright snapshots 👌🏽 |
|
Arf don't mind the UI tests, they seem to fail in an unrelated way. Let's merge your PR, thanks! |
martinRenou
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for compatibility with other extensions (like jupyterlab-git) that register listeners on FileBrowserModel.pathChanged.
Tested locally with
jupyterlab-git. Before change, the plugin is unable to detect that you are in a git repo when clicking on directory containing a git repo. After change, plugin is able to detect presence of git repo based on last clicked path.