Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESC key and click outside modal do not stop exit tour. #58

Open
girdevstack opened this issue Jul 11, 2022 · 2 comments
Open

ESC key and click outside modal do not stop exit tour. #58

girdevstack opened this issue Jul 11, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@girdevstack
Copy link

girdevstack commented Jul 11, 2022

Description

When attempting to exit any tour using the esc key or clicking outside the modal, the tour continues on to the next step.

Reproduce

  1. Go to help menu
  2. Click on any tour
  3. Start tour
  4. Attempt to click outside of tour
  5. Attempt to exit tour using `esc key
  6. Attempt to close clicking "X" on window
    • Tour continues -

Expected behavior

When a user presses the esc key or clicks outside the tour, the tour should be exited and they should regain control of their notebook session instead of continuing the tour.

Context

Python 3.9.7
jupyter-client 7.1.1
jupyter-core 4.9.1
jupyterlab 3.2.8
jupyterlab-tour 3.1.4

@girdevstack girdevstack added the bug Something isn't working label Jul 11, 2022
@fcollonval
Copy link
Member

Thanks for the suggestion.

I can provide some pointers if you wish to submit a PR.

@fcollonval
Copy link
Member

Testing it right now, it happens only on the first step. When pressing ESC on others steps (or clicking on the overlay), the tour is paused as expected. It may be a bug in react-joyride library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants