You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When attempting to exit any tour using the esc key or clicking outside the modal, the tour continues on to the next step.
Reproduce
Go to help menu
Click on any tour
Start tour
Attempt to click outside of tour
Attempt to exit tour using `esc key
Attempt to close clicking "X" on window
Tour continues -
Expected behavior
When a user presses the esc key or clicks outside the tour, the tour should be exited and they should regain control of their notebook session instead of continuing the tour.
Testing it right now, it happens only on the first step. When pressing ESC on others steps (or clicking on the overlay), the tour is paused as expected. It may be a bug in react-joyride library.
Description
When attempting to exit any tour using the
esc
key or clicking outside the modal, the tour continues on to the next step.Reproduce
help
menuExpected behavior
When a user presses the
esc
key or clicks outside the tour, the tour should be exited and they should regain control of their notebook session instead of continuing the tour.Context
Python 3.9.7
jupyter-client 7.1.1
jupyter-core 4.9.1
jupyterlab 3.2.8
jupyterlab-tour 3.1.4
The text was updated successfully, but these errors were encountered: