-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve performance of jupyterlab-quickopen #3
Comments
One thing I found helpful is excluding some files. Try this |
Maybe it makes things more convenient to allow specifying include pattern? |
It is possible to delay the indexing of jupyterlab-quickopen after launching the jupyterlab server? Slowing down launching of JupterLab server is a hard no to me. |
@dclong The scan operation is only performed when a get is performed: https://github.com/parente/jupyterlab-quickopen/blob/ca55830e460be6f934d83642425c073d3e2fc284/jupyterlab_quickopen/handler.py#L81 I've not seen the slow down when jupyterlab opens myself. I'll be happy to review a pull request if you are able to debug the problem and submit a fix. |
I love the extension jupyterlab-quickopen. It's (potentially) resolves server issues that I opened in jupyterlab repository. jupyterlab/jupyterlab#3246 is resolved by this extension. jupyterlab/jupyterlab#5056 and jupyterlab/jupyterlab#5481 are probably no longer needed with this extension.
However, I do see performance issues when there are lots of files in the JupyterLab work directory. It also significantly increase the launch time of JupyterLab server when there are lots of files.
The text was updated successfully, but these errors were encountered: