Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of jupyterlab-quickopen #3

Open
dclong opened this issue Jan 28, 2019 · 5 comments
Open

Improve performance of jupyterlab-quickopen #3

dclong opened this issue Jan 28, 2019 · 5 comments

Comments

@dclong
Copy link

dclong commented Jan 28, 2019

I love the extension jupyterlab-quickopen. It's (potentially) resolves server issues that I opened in jupyterlab repository. jupyterlab/jupyterlab#3246 is resolved by this extension. jupyterlab/jupyterlab#5056 and jupyterlab/jupyterlab#5481 are probably no longer needed with this extension.

However, I do see performance issues when there are lots of files in the JupyterLab work directory. It also significantly increase the launch time of JupyterLab server when there are lots of files.

@bobmayuze
Copy link

One thing I found helpful is excluding some files. Try this

@dclong
Copy link
Author

dclong commented Mar 7, 2020

Maybe it makes things more convenient to allow specifying include pattern?

@dclong
Copy link
Author

dclong commented Mar 7, 2020

It is possible to delay the indexing of jupyterlab-quickopen after launching the jupyterlab server? Slowing down launching of JupterLab server is a hard no to me.

@parente
Copy link
Member

parente commented Mar 8, 2020

@dclong The scan operation is only performed when a get is performed: https://github.com/parente/jupyterlab-quickopen/blob/ca55830e460be6f934d83642425c073d3e2fc284/jupyterlab_quickopen/handler.py#L81

I've not seen the slow down when jupyterlab opens myself. I'll be happy to review a pull request if you are able to debug the problem and submit a fix.

@machow
Copy link

machow commented Apr 19, 2020

In case anyone is running into this now--it looks like there is an undocumented relativeSearch setting. If you set it to true, then it will search from the folder you have opened in jupyter lab. Really enjoying the extension!

You can set it using the settings instruction in the README.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants