Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default urlpath/filepath configurable from a file in repo? #369

Open
consideRatio opened this issue Aug 5, 2018 · 2 comments
Open

Default urlpath/filepath configurable from a file in repo? #369

consideRatio opened this issue Aug 5, 2018 · 2 comments

Comments

@consideRatio
Copy link
Member

Wouldn't it be proper to have a setting to indicate what the default urlpath / filepath should be for repo2docker? It is currently a logic on the binderhub level, but I figure it makes sense to have support for this within repo2docker directly as well.

I just built a repo with jupyterlab etc isntalled with repo2docker (master) and entered the classic Jupyter UI, somewhat of a letdown.

@betatim
Copy link
Member

betatim commented Aug 6, 2018

Maybe a starting point is to have a --filepath and --urlpath argument to repo2docker that let you configure this. Most of this would be editing the URL printed by the notebook at the end. Unsure how hard it is to do that.

@manics
Copy link
Member

manics commented Sep 18, 2020

One option is to make this part of the specification for describing a decoupled UI: #868

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants