-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test failures in main branch #449
Comments
@bollwyvl I'm stumped, it sais I tried opening a chrome inspector console and doing Do you have ideas on debugging / resolving this issue? |
yes, 4.1 and 7.1 created breaking changes in the DOM. |
@bollwyvl ah thanks, I'm making progress now! |
I think this could be a good case for using dependabot to pin some dependencies for CI testing. Keep the dev dependencies unrestricted in pyproject.toml, but use a separate dev-ci-requirements.txt file for CI only and let dependabot tell us when there's a UI change in lab or notebook. |
There are acceptance test failures in main branch (example here).
A key part of the failure is:
They seem to show up due to this part:
jupyter-server-proxy/tests/acceptance/Notebook.robot
Lines 11 to 13 in 9b624c4
And specifically with
notebook==7.1.1
but not withnotebook==7.0.8
.I understand those expressions to be selecting a specific HTML element, but I think if it worked once it should work later as I see no difference in the HTML looking at it with old/new versions.
The text was updated successfully, but these errors were encountered: