Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proxy-timeout option #86

Merged
merged 2 commits into from
Oct 4, 2016
Merged

Add proxy-timeout option #86

merged 2 commits into from
Oct 4, 2016

Conversation

ashishdahiya
Copy link
Contributor

http-proxy lib provides a proxyTimeout option that allows us to set a timeout on the outgoing socket connection to the target. This timeout is very effective when the upstream target does not respond within an expected time.

I had wasted a few hours searching for this option. Documenting this option can save others a significant amount of time.

http-proxy lib provides a proxyTimeout option (https://github.com/nodejitsu/node-http-proxy/blob/master/lib/http-proxy/passes/web-incoming.js#L122) that allows us to set a timeout on the outgoing socket connection to the target. This timeout is very effective when the upstream target does not respond within an expected time.

I had wasted a few hours searching for this option. Documenting this option can save others a significant amount of time.
@minrk
Copy link
Member

minrk commented Oct 3, 2016

While this adds a CLI option, it doesn't hook it up to anything, so it won't have any effect. Do you want to add options.proxyTimeout = args.proxyTimeout?

@ashishdahiya
Copy link
Contributor Author

You are correct. I missed that. I have added it now. PTAL.

@minrk minrk merged commit 3eb8dfb into jupyterhub:master Oct 4, 2016
@minrk
Copy link
Member

minrk commented Oct 4, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants