Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically update package.json version from setup.py #1692

Open
manics opened this issue May 3, 2023 · 6 comments
Open

Automatically update package.json version from setup.py #1692

manics opened this issue May 3, 2023 · 6 comments

Comments

@manics
Copy link
Member

manics commented May 3, 2023

Proposed change

An additional version string was added in #1689:

Can we link this up to setup.py so that the version is automatically updated to match the BinderHub version?

Alternative options

Do nothing

Who would use this feature?

It would ensure all the npm package version matches the BinderHub version

@manics manics changed the title Automatically update package.json version from versioneer Automatically update package.json version from setup.py May 3, 2023
@yuvipanda
Copy link
Collaborator

Would this mean we need to publish a version to PyPI each time we publish to npm?

@manics
Copy link
Member Author

manics commented May 3, 2023

If we want automated releases (#1666) then yes.... unless we can have some logic to conditionally publish one package but not the other?

@yuvipanda
Copy link
Collaborator

IMO the breaking changes in these two packages might differ, so I think it's probably ok to version these separately?

@consideRatio
Copy link
Member

We have adopted use pf tbump quite systematically with success and positive feedback, instead of writing code in setup.py, i suggest we hardcode it and let tbump update it in all locations we have the string.

For practical reasons I prefer to see only have one version to track for all parts in this repo, even if it could make sense to let a js client drift.

@yuvipanda
Copy link
Collaborator

Given there seems to be consensus on this, I'm happy to go with it especially as other people are doing the work :D :D

@manics
Copy link
Member Author

manics commented May 3, 2023

I think we should keep versioneer (or some other automated versioning tool) because we're installing dev versions of BinderHub in production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants