From 681466c012ee71fa9288a88895f985d4ffe87ab6 Mon Sep 17 00:00:00 2001 From: Erik Sundell Date: Mon, 10 Oct 2022 16:21:03 +0200 Subject: [PATCH] Omit configuration of oauth_client_id, rely on its default value --- doc/authentication.rst | 1 - testing/local-binder-k8s-hub/binderhub_config_auth_additions.py | 2 +- .../jupyterhub-chart-config-auth-additions.yaml | 1 - 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/doc/authentication.rst b/doc/authentication.rst index 49c2177f9d..f2f7e4f32c 100644 --- a/doc/authentication.rst +++ b/doc/authentication.rst @@ -26,7 +26,6 @@ you need to add the following into ``config.yaml``: binder: oauth_no_confirm: true oauth_redirect_uri: "https:///oauth_callback" - oauth_client_id: "binder-oauth-client-test" singleuser: # to make notebook servers aware of hub diff --git a/testing/local-binder-k8s-hub/binderhub_config_auth_additions.py b/testing/local-binder-k8s-hub/binderhub_config_auth_additions.py index 5a54e56654..5e68f0e88e 100644 --- a/testing/local-binder-k8s-hub/binderhub_config_auth_additions.py +++ b/testing/local-binder-k8s-hub/binderhub_config_auth_additions.py @@ -25,4 +25,4 @@ c.HubOAuth.base_url = c.BinderHub.base_url c.HubOAuth.hub_prefix = c.BinderHub.base_url + "hub/" c.HubOAuth.oauth_redirect_uri = "http://127.0.0.1:8585/oauth_callback" -c.HubOAuth.oauth_client_id = "binder-oauth-client-test" +c.HubOAuth.oauth_client_id = "service-binder" diff --git a/testing/local-binder-k8s-hub/jupyterhub-chart-config-auth-additions.yaml b/testing/local-binder-k8s-hub/jupyterhub-chart-config-auth-additions.yaml index 9ec6df348b..280a749655 100644 --- a/testing/local-binder-k8s-hub/jupyterhub-chart-config-auth-additions.yaml +++ b/testing/local-binder-k8s-hub/jupyterhub-chart-config-auth-additions.yaml @@ -6,7 +6,6 @@ hub: binder: oauth_no_confirm: true oauth_redirect_uri: "http://127.0.0.1:8585/oauth_callback" - oauth_client_id: "binder-oauth-client-test" config: JupyterHub: authenticator_class: "dummy"