Fix CI #226
Merged
Fix CI #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
trungleduc
force-pushed
the
fix-ci
branch
3 times, most recently
from
23a244c
to
34979fb
Compare
trungleduc
force-pushed
the
fix-ci
branch
10 times, most recently
from
ae6a224
to
737c0a8
Compare
|
I'll update the UI test snapshot in the follow-up since the updated Galata bot script needs to be on main |
martinRenou
requested changes
Nov 23, 2023
| @@ -0,0 +1 @@ | |||
| export default null as any; | |||
There was a problem hiding this comment.
What is the purpose of this? Is this for TypeScript to copy over the js file into lib/?
There was a problem hiding this comment.
This file is there to make tsc happy and compile without buiding occ.js into 'src'. It is not copied to lib. The real file in lib is provided by webpack in the occ build process.
ui-tests/tests/notebook.spec.ts-snapshots/dark-Notebook-ipynb-cell-2-linux.png
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #224
Code change
jupytercadmeta package@jupytercad/opencascadebuild scriptcheck-pythonstep in the check release workflow.