Refactor Bounding Box Logic #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjxn-py
force-pushed
the
bbox-visible
branch
from
b651d48
to
0c7f143
Compare
|
Preview PR at appsharing.space |
|
Integration tests repot: appsharing.space |
trungleduc
reviewed
Oct 30, 2024
trungleduc
approved these changes
Oct 30, 2024
|
Thanks! |
Co-authored-by: Duc Trung Le <[email protected]>
martinRenou
reviewed
Oct 30, 2024
| boundingBox.position.copy(center); | ||
| boundingBox.visible = false; | ||
| boundingBox.name = SELECTION_BOUNDING_BOX; | ||
| meshGroup.add(boundingBox); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shall close #545
Shall also close #526
bbox.mov