Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add setColor api #552

Merged
merged 10 commits into from
Oct 29, 2024
Merged

Re-add setColor api #552

merged 10 commits into from
Oct 29, 2024

Conversation

arjxn-py
Copy link
Member

Shall close #423

@arjxn-py arjxn-py added the bug PR that fixes a bug label Oct 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 28, 2024 •
edited
Loading

Integration tests repot: appsharing.space

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 28, 2024 •
edited
Loading

Preview PR at appsharing.space

@arjxn-py arjxn-py marked this pull request as draft October 28, 2024 08:42
@trungleduc
Copy link
Member

The old API set_color(self, object_name, color) is still missing?

@arjxn-py
Copy link
Member Author

The old API set_color(self, object_name, color) is still missing?

Yes, i'll recreate a method for that

@arjxn-py arjxn-py marked this pull request as ready for review October 28, 2024 13:48
@arjxn-py
Copy link
Member Author

Bot please update snapshots

@trungleduc trungleduc closed this Oct 28, 2024
@trungleduc trungleduc reopened this Oct 28, 2024
@trungleduc
Copy link
Member

Thanks!

@SylvainCorlay SylvainCorlay merged commit e94e6ad into jupytercad:main Oct 29, 2024
10 checks passed
@arjxn-py arjxn-py deleted the setColor-api branch November 3, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trungleduc trungleduc trungleduc approved these changes

Assignees
No one assigned
Labels
bug PR that fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-add setColor api
3 participants
@arjxn-py @trungleduc @SylvainCorlay