Use logarithmic depth buffer #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Integration tests repot: appsharing.space |
|
Preview PR at appsharing.space |
for more information, see https://pre-commit.ci
|
Bot please update snapshots |
martinRenou
commented
Oct 17, 2024
arjxn-py
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Works well, thanks @martinRenou
The failure looks unrelated, maybe you want to re-trigger that one?
|
The visual regression makes me nervous though, I don't understand why the color of the box changes in that case |
It must be since the |
|
Ok well let's go and merge! Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents visual artifacts with big/small objects