Update jupyter-collaboration v3.0.0-beta.8 #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 15, 2024
Maybe this is the cause of the failures? |
Type 'JupyterCadDoc' is missing the following properties from type 'YDocument<DocumentChange>': source, getSource, setSource
src/stepplugin/plugins.ts(61,9): error TS2322: Type '() => JupyterCadStepDoc' is not assignable to type 'SharedDocumentFactory'.
Type 'JupyterCadStepDoc' is missing the following properties from type 'YDocument<DocumentChange>': source, getSource, setSource
src/stlplugin/plugins.ts(61,9): error TS2322: Type '() => JupyterCadStlDoc' is not assignable to type 'SharedDocumentFactory'.
Type 'JupyterCadStlDoc' is missing the following properties from type 'YDocument<DocumentChange>': source, getSource, setSourcewe need to update these classes? |
|
Yes, see jupyter-server/jupyter_ydoc#273. |
you can add |
|
Preview PR at appsharing.space |
|
Integration tests repot: appsharing.space |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #471.
yjs-widgets will also have to use jupyter-collaboration v3.