-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Final review of JEP #5
Comments
Sorry for the late reply. No objections! I'm actually in favor to just post the JEP as-is with some quick fixes and iterate. We're going to get feedback regardless. |
Ok that's fine with me! You want to go ahead and submit the PR? |
Done, finally jupyter/enhancement-proposals#41
|
Great, thanks @jaipreet-s! I'll let you know if/when I run into issues pushing commits to your fork. |
I've invited @Zsailer and @yuvipanda as "Collaborators" on my fork so you should be able to push. Let me know if there's another preferred way or the permissions aren't pushed. Additionally, I've @ tagged you guys on some of the feedback in the JEP. |
I'm going to do a final review of the documentation today (mostly to standardize
emit
vs.record_event
in places), then I think we should submit this JEP tojupyter/enhancement-proposals
tomorrow. Any objections? @jaipreet-s @yuvipandaThe text was updated successfully, but these errors were encountered: