Updated fav-icon Base URL from JupyterLab PageConfig. #7109
Conversation
|
|
| @@ -422,10 +426,10 @@ const tabIcon: JupyterFrontEndPlugin<void> = { | |||
| ) as HTMLLinkElement; | |||
| switch (status) { | |||
| case 'busy': | |||
| link.href = busyIcon; | |||
| link.href = baseURL + busyIcon; | |||
There was a problem hiding this comment.
Should this string concatenation be moved above where notebookIcon and busyIcon are defined?
There was a problem hiding this comment.
Also it could be combined with URLExt.join() (some example uses in this repo).
There was a problem hiding this comment.
Thanks for the Quick review. This will be more readable. have Updated the PR.
|
@jtpio could u please guide me about why Build / Test Lint (pull_request) is failing?, Logs of the job are pointing to file /notebook/blob/main/notebook/app.py. |
|
The lint failure looks related to an upstream change, maybe this new release? https://github.com/jupyter-server/jupyter_server/releases/tag/v2.8.0 Similar to #7104, we can fix that separately. |
|
FYI @jayeshsingh9767 I've updated the branch to include #7104, which should hopefully help fix the CI. |
|
The new failure can likely be fixed by running |
| @@ -38,6 +38,9 @@ import { Widget } from '@lumino/widgets'; | |||
|
|
|||
| import { TrustedComponent } from './trusted'; | |||
|
|
|||
| import { PageConfig, URLExt } from '@jupyterlab/coreutils'; | |||
There was a problem hiding this comment.
These imports can be grouped with the other imports above.
There was a problem hiding this comment.
Got it will update the PR.
|
Thanks @jtpio |
We were Getting 404 because base URL of binder(different base url) was used for fetching fav-icons I have update code to use Base URL from JupyterLab PageConfig.
This closes issue #7076