Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling regressions in Notebook 7 tab bar #6730

Closed
JasonWeill opened this issue Feb 13, 2023 · 3 comments · Fixed by #6738
Closed

Styling regressions in Notebook 7 tab bar #6730

JasonWeill opened this issue Feb 13, 2023 · 3 comments · Fixed by #6738
Labels
Milestone

Comments

@JasonWeill
Copy link
Collaborator

Describe the bug
CSS issues in Notebook 7 tab bar include that:

  1. There is no dark background (as in JupyterLab 4) in the space to the right of the rightmost tab.
  2. The tab bar boundary is very slightly (1 pixel?) higher than the top of each individual tab
  3. The rightmost edge of the tab bar slightly overhangs the right edge of the active tab's container.

image

To Reproduce
Steps to reproduce the behavior:

  1. Launch Notebook 7
  2. See behaviors above

Expected behavior
A clear and concise description of what you expected to happen.

  1. There should be a darker background for the negative space than for any active or inactive tab.
  2. The tab bar boundary should be even with or lower than the top of any tab.
  3. The rightmost edge of the tab bar should be flush with the right edge of the active tab container, with a drop shadow to match.

Screenshots

See above

Desktop (please complete the following information):

  • OS: macOS 12.6.3
  • Browser: Firefox
  • Version: 102.7.0esr
@JasonWeill JasonWeill added the bug label Feb 13, 2023
@JasonWeill JasonWeill added this to the 7.0 milestone Feb 13, 2023
@jupyterlab-probot jupyterlab-probot bot added the status:Needs Triage Applied to issues that need triage label Feb 13, 2023
@jtpio
Copy link
Member

jtpio commented Feb 14, 2023

Thanks @JasonWeill for reporting this 👍

There is no dark background (as in JupyterLab 4) in the space to the right of the rightmost tab.

Which JupyterLab component are you referring to? JupyterLab uses a DockPanel but Notebook 7 doesn't. Maybe that's why the styles are not applied here?

@jtpio
Copy link
Member

jtpio commented Feb 14, 2023

Also wondering if we should follow the style used in Jupyterlab, or maybe try to be closer to the classic notebook UI: #6397

@jtpio
Copy link
Member

jtpio commented Feb 20, 2023

FYI @JasonWeill #6738 made some tweaks to the file browser UI:

image

Which can be tested on Binder: https://mybinder.org/v2/gh/jupyter/notebook/main?urlpath=tree

Feel free to open an issue if you think there is still room for improvements, thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants