Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide the debugger button on mobile #6556

Closed
jtpio opened this issue Oct 6, 2022 · 2 comments · Fixed by #6731
Closed

Hide the debugger button on mobile #6556

jtpio opened this issue Oct 6, 2022 · 2 comments · Fixed by #6731
Milestone

Comments

@jtpio
Copy link
Member

jtpio commented Oct 6, 2022

#6487 added the debugger extension by default.

This shows the debugger button in the notebook toolbar:

image

However on mobile it might not make sense to support debugging since the viewport is usually much smaller:

image

We should consider hiding the debugger button on mobile by default to at least make it more difficult to start the debugger by mistake (menu items are left untouched).

@jupyterlab-probot jupyterlab-probot bot added the status:Needs Triage Applied to issues that need triage label Oct 6, 2022
@jtpio jtpio added this to the 7.0 milestone Oct 6, 2022
@jtpio jtpio added enhancement and removed status:Needs Triage Applied to issues that need triage labels Oct 6, 2022
@l3atjin
Copy link

l3atjin commented Dec 3, 2022

Hi @jtpio. Can I have a go at this?

@jtpio
Copy link
Member Author

jtpio commented Dec 5, 2022

Sure that would be great, thanks @l3atjin!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants