Improve the About dialog

[jtpio]

The look of the current "About" dialog could be improved:

As a comparison this is what the about dialog in JupyterLab looks like:

Maybe the notebook dialog could be aligned to look more like the one in JupyterLab, and also display a link to the contributor list.

[jtpio]

This is where the About dialog is created:

notebook/packages/help-extension/src/index.tsx

Lines 119 to 161 in e8e0f8f

	const title = (
	<>
	<span className="jp-AboutNotebook-header">
	<jupyterIcon.react width="196px" height="auto" />
	</span>
	</>
	);
	const notebookURL = 'https://github.com/jupyter/notebook';
	const linkLabel = trans.__('JUPYTER NOTEBOOK ON GITHUB');
	const externalLinks = (
	<span>
	<a
	href={notebookURL}
	target="_blank"
	rel="noopener noreferrer"
	className="jp-Button-flat jp-AboutNotebook-about-externalLinks"
	>
	{linkLabel}
	</a>
	</span>
	);
	const version = trans.__('Version: %1', app.version);
	const body = (
	<>
	<span className="jp-AboutNotebook-body">{version}</span>
	<div>{externalLinks}</div>
	</>
	);
	const dialog = new Dialog({
	title,
	body,
	buttons: [
	Dialog.createButton({
	label: trans.__('Dismiss'),
	className:
	'jp-AboutNotebook-about-button jp-mod-reject jp-mod-styled'
	})
	]
	});
	dialog.addClass('jp-AboutNotebook');
	void dialog.launch();

[krassowski]

The Notebook v6 About dialog was even more informative:

In particular, showing jupyter-server version (and maybe also the Python version it is running on) might be worth considering since the server and frontend versions are now decoupled.

I think I remember that the kernel info was a separate menu item in JupyterLab at some point but I cannot find it any more - either a regression or I am wrong and it was never implemented.

[davinderpalrehal]

Is someone working on this issue? If not I would like to have a crack at it.

[jtpio]

@davinderpalrehal feel free to pick it up and open a PR, even it's just a work-in-progress. Thanks!

[kostyafarber]

@davinderpalrehal you still working on this?

[davinderpalrehal]

@kostyafarber plans are to work on this over the weekend, is it time sensitive? If it's needed urgently I don't mind if someone else picks it up, my intention was to have the PR open by Monday.

[kostyafarber]

Oh no go ahead! Just wanted to make sure if you weren't working on it I could pick it up. Thanks.

[davinderpalrehal]

Sounds good, thanks @kostyafarber.

[davinderpalrehal]

Hey @kostyafarber , I couldn't finish setting up the repo on my laptop and get it up and running, if you are still free please proceed with picking this issue up.

[kostyafarber]

No worries @davinderpalrehal I'll try check it out

[dohrisalim]

Is this issue still open? @kostyafarber @jtpio

[kostyafarber]

If you think there are further improvements to be made and the maintainers agree, please go ahead!

[jtpio]

We could probably do a quick pass on the CSS to style the links. This is what it looks like at the moment:

[Tony-j77]

Finishing this issue :)

[AdityaGirdhar]

@jtpio Do you have any more improvements in mind? Maybe adding some more information like Notebook v6 had (showing jupyter-server version, and also the Python version it is running on). I've a university break starting from next week and I'd love to contribute.

[krassowski]

Of note the odd hover style seen on the screenshot in original issue is an upstream issue in JupyterLab. Contributions to solve: jupyterlab/jupyterlab#14084 are welcome!

[Aryasarkar008]

hey is this issue still open?? is someone still working on it??

[yjrab]

Is this issue still open? @jtpio
Any help needed regarding the CSS of the About dialog?

[andrii-i]

Hi @yjrab! Thank you for taking interest in fixing this issue. You are not required to ask for a permission to work on such issue, please feel free to open a pull request with proposed implementation.

[andrii-i]

Here is the css of "About" dialog in JupyterLab, can be used for reference: https://github.com/jupyterlab/jupyterlab/blob/e0b4de1eb37c9dd37c11e5319ed00cb8d37b8d92/packages/help-extension/style/base.css

[yjrab]

Thank you @andrii-i for you reply.
I will check the reference and propose something accordingly.

[Razeeeeeeeeeee]

Hey @andrii-i,
Is this issue still open?
I'd like to work on it

[andrii-i]

Hi @Razeeeeeeeeeee. Please feel free to work on it and open a PR when ready.