[6.4.x] CI failures on 6.4.x branch

[echarles]

After reviewing the open PRs on the 6.4.x branch, the selenium and javascript tests all fail. This is probably coming from the CI, and not from the respective PRs.

I am not sure what the status was before the creation of that 6.4.x branch. @Zsailer or @jtpio any thoughts on this?

So far we have the following recurring failures:

• check_release (link_check) Use place-hold.it instead of plaecehold.it to create image placeholders #6320
• Linux JS Tests / build (macos and ubuntu, notebook): Use var instead of const in sanitizer to partially fix ci js tests #6354
• build windows 3.x notebook/terminal/tests/test_terminals_api.py

[jtpio]

@echarles the CI on this repo has been failing for many weeks / months. See this comment for reference: #6213 (comment)

There hasn't been that much effort put into fixing it because:

• the repo was (and the 6.x is) in maintenance mode
• there was no plan to merge anything significant related to 6.x, except maybe get bower dependencies from npm #6213

[echarles]

Thx @jtpio for the info. I have updated the initial comment to track the issues and their fixes.

cc/ @kevin-bates

[echarles]

For the Linux JS Tests, an issue is related to the waitForPopup which does not anymore do the expected job

notebook/notebook/tests/util.js

Lines 30 to 35 in 232f724

	this.waitForPopup('');
	this.withPopup('', function () {this.waitForSelector('.CodeMirror-code');});
	this.then(function () {
	this.open(this.popups[0].url);
	});

I have tried to force the popup url without luck. This may come from the webkit evolution, and how the tab opening are handled and recognized by casperjs. I have tried with slimerjs option, downgrading my firefox to version 59 as documented on https://github.com/laurentj/slimerjs, but got segmentation fault while running the test.

[echarles]

Unless a solution can be found to let webpack generate phantomjs friendly javascript (#6354 (comment)), a workaround solution would be to change the sanitizer index.js when running the CI.

[echarles]

Progressing well on js-test:

• base: green ✅ https://github.com/jupyter/notebook/runs/5984992097?check_suite_focus=true

• services: FAIL 82 tests executed in 70.297s, 74 passed, 8 failed, 0 dubious, 0 skipped. on https://github.com/jupyter/notebook/runs/5984992147?check_suite_focus=true - I see errors like ModuleNotFoundError: No module named 'IPython.kernel' - CI runs pip install .[test] so this sounds strange. Any idea @blink1073 ?

• notebook: FAIL 523 tests executed in 138.55s, 522 passed, 1 failed, 0 dubious, 0 skipped. on https://github.com/jupyter/notebook/runs/5984992187?check_suite_focus=true - Just one failure I will investigate locally

 type: assertEquals
#    file: /Users/runner/work/notebook/notebook/notebook/tests/notebook/roundtrip.js
#    subject: "stream"
#    expected: "display_data"

[blink1073]

The class moved: https://github.com/ipython/ipykernel/blob/d7339c2c70115bbe6042880d29eeb273b5a2e350/ipykernel/comm/comm.py#L15

[echarles]

For now, terminals tests are failing on windows.

A few remaining javascript tests are still failing (base as successfull, 3/94 are failing for service, 1/522 for notebook although they all succeed on my macbook laptop)

 service
 https://github.com/jupyter/notebook/runs/5988174768?check_suite_focus=true
 FAIL 94 tests executed in 91.399s, 91 passed, 3 failed, 0 dubious, 0 skipped.   
 /Users/runner/work/notebook/notebook/notebook/tests/services/kernel.js
  Untitled suite in /Users/runner/work/notebook/notebook/notebook/tests/services/kernel.js
    uncaughtError: "function () {
        return this.evaluate(function (events) {
            return IPython._events_triggered.length >= events.length;
        }, [events]);
    }" did not evaluate to something truthy in 20000ms
In /Users/runner/work/notebook/notebook/notebook/tests/services/kernel.js
  Untitled suite in /Users/runner/work/notebook/notebook/notebook/tests/services/kernel.js
    assertEquals: failed_restart: 3 events were triggered
In /Users/runner/work/notebook/notebook/notebook/tests/services/session.js
  Untitled suite in /Users/runner/work/notebook/notebook/notebook/tests/services/session.js
    uncaughtError: "function () {
        return this.evaluate(function (events) {
            return IPython._events_triggered.length >= events.length;
        }, [events]);
    }" did not evaluate to something truthy in 20000ms

 notebook
 https://github.com/jupyter/notebook/runs/5988174549?check_suite_focus=true
 /Users/runner/work/notebook/notebook/notebook/tests/notebook/roundtrip.js
 FAIL 523 tests executed in 156.874s, 522 passed, 1 failed, 0 dubious, 0 skipped.
    this.then(function ( ) {
        check_output_area.apply(this, ['execute_result', ['text', 'svg']]);
    });
```