Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide on merging strategy for retrolab into notebook #6225

Closed
tonyfast opened this issue Nov 10, 2021 · 6 comments
Closed

Decide on merging strategy for retrolab into notebook #6225

tonyfast opened this issue Nov 10, 2021 · 6 comments

Comments

@tonyfast
Copy link
Collaborator

@Zsailer @jtpio let us use this issue to discuss the plans for retrolab into notebook.

@tonyfast tonyfast moved this from Todo Pre Release to In Progress Issues in Notebook v7 Nov 10, 2021
@jtpio
Copy link
Member

jtpio commented Nov 10, 2021

Thanks @tonyfast for starting this and setting up the board to track issues 👍

Pasting the meeting notes here for reference:


  • where to handle discussions knowing we're replacing one technology with another.
  • Technical steps/questions
    • Do we move retrolab into jupyter/notebook?
    • Dis-entangling NBClassic, JupyterLab, and Notebook
      • NBClassic depends on Notebook and JupyterLab depends on NBClassic.
      • Making RetroLab become Notebook 7.x forces JupyterLab to drop NBClassic as dependency or NBClassic drops it's notebook dependency.
      • Pin nbclassic to 6.x.

@jtpio
Copy link
Member

jtpio commented Nov 10, 2021

Practically speaking:

  • RetroLab still needs a place to track issues for development. Moving to jupyter/notebook would probably mean moving the development effort to the repo as well
  • RetroLab would need to update its /retro/tree, /retro/notebooks... endpoints to /tree, /notebooks...
  • Some of the dependency management issues mentioned above need to be thought through to ensure the best pip install --pre notebook experience

Apart from that, the first pre-release of notebook 7 could ship retrolab almost as is (after fixing the points mentioned above)

@tonyfast
Copy link
Collaborator Author

i think when we merge the project histories we can transfer issues from retrolab to notebook. there are enough to probably do by hand. the caveat is

You can only transfer issues between repositories owned by the same user or organization account. You can't transfer an issue from a private repository to a public repository. https://docs.github.com/en/issues/tracking-your-work-with-issues/transferring-an-issue-to-another-repository

so we'll need notebook in the jupyterlab repo to make this work.

@jtpio
Copy link
Member

jtpio commented Nov 10, 2021

Otherwise Meeseek can create new issues on the target repo, for example: jupyter-server/jupyter_server#533

@jtpio
Copy link
Member

jtpio commented Nov 11, 2021

While that merge implies publishing under the notebook name on PyPI, we should also consider changing the name of the underlying JS packages published to npm.

For now they are under the @retrolab organization, for example: https://www.npmjs.com/package/@retrolab/application

It would have been nice to publish them under @notebook which unfortunately seems to already be taken. I have created the @jupyter-notebook organization on npm just in case for now. Happy to use something else if anyone has other suggestions.

We could also publish under the @jupyterlab organization, and add an extra prefix to distinguish the packages from the core JupyterLab packages.

@jtpio
Copy link
Member

jtpio commented Mar 11, 2022

The RetroLab code base has been integrated in the notebook repo, and the first 7.0 pre-release is out. See the following links for more context:

Transferring issues from retrolab to notebook is tracked in jupyter/notebook-team-compass#9.

Closing as fixed, thanks all!

@jtpio jtpio closed this as completed Mar 11, 2022
Repository owner moved this from In Progress Issues to Done in Notebook v7 Mar 11, 2022
@jtpio jtpio added this to the 7.0 milestone Mar 11, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants