Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky JavaScript tests omnibus ticket #2243

Open
ivanov opened this issue Mar 2, 2017 · 2 comments
Open

Flaky JavaScript tests omnibus ticket #2243

ivanov opened this issue Mar 2, 2017 · 2 comments

Comments

@ivanov
Copy link
Member

ivanov commented Mar 2, 2017

Our CasperJS tests have a reputation for being at times flaky, primarily due to race conditions and the asynchronous nature of javascript. I am opening this ticket so we can document any time we find Continuous Integration (Travis, etc) tests are failing, so we can track down the race conditions and eliminate them.

Edit: Additionally, I think it won't hurt to put up an extra link to our documentation of how to write, run, and wrap your head around our notebook Javascript tests.

@mpacer
Copy link
Member

mpacer commented Mar 2, 2017

@michaelpacer, commenting so notifications from this get priority.

@takluyver
Copy link
Member

We started using travis_retry on our JS tests on Travis, because we were forever manually restarting failed builds when we suspected a race condition. travis_retry re-runs a command if it fails, up to three times. So be aware that you're probably not seeing most of the test failures.

I'm well aware that this is bad practice too, of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants