Bidi Support design proposal for (Numeric Shaping , National Calendar and UI Mirroring)

[samarsultan]

This is the proposed low level design of the three requested bidi features ( #2156 , #2154 and #1852 ).

• Creation of bidi / js folders under notebook/static to wrap the whole bidi work as the below screenshot.

• Under bidi /js there will be two files:

  • bidi.js: the interface that hold the bidi function to be invoked.
  • numericshaping.js: has the core functions of numeric shaping support.

• Following is bidi.js in more details:
  The bidi API contains the following functions with respect to each feature:

At the moment , I need any UI component to control the user preference if we enable the bidirectional behavior.

Thanks and Waiting your Comments .

[Carreau]

Sorry I'm not subscribe to all the notification and missed this. I'll try to have a look, but I have plenty to do in the next 2 weeks.

[Carreau]

At the moment , I need any UI component to control the user preference if we enable the bidirectional behavior.

With master that's relatively easy to do, there is a command (Ctrl-Shift-P, toggle rtl layout) that allow you to set/unset the rtl flag on body. I've bound it on my system to Ctrl-r,t,l

I'll trust you on function naming and usage.

@jasongrout @blink1073 any feedback on the naming as we'd likely want to mirror this in TS/JupyterLab ?

[blink1073]

The naming conventions look good to me. In TS we'd type the options as 'default' | 'national' | 'contextual', for example, but otherwise it should be the same.