-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The future of nbclassic #81
Comments
cc @tonyfast @jtpio @SylvainCorlay from our last notebook meeting. also, cc @fperez @afshin, since we talked about this briefly when drafting the notebook JEP. |
Thanks @Zsailer for raising this.
Maybe this would be the less disruptive approach, and would require minimal effort? And this could be extracted to its own Linking to jupyterlab/jupyterlab#11894 which drops |
Posting here more ideas that have been discussed at the Notebook Weekly calls: jupyter/notebook-team-compass#5 If we still want users to be able to use the classic notebook frontend after Notebook v7 final is released, one way could be to let
That way it might still be possible to allow installing JupyterLab 4, Notebook 7 and NBClassic alongside without conflicts. |
This means we'd move the classic notebook Javascript into the nbclassic repo and allowing it to live on indefinitely. A follow up question is, how do we handle the git history? I'm inclined to say we just move the code here in a PR and not worry about trying to disentangle the old commit history. |
We have now a plan for the future as documented on jupyter/notebook-team-compass#5 (comment)
I have opened a PR that takes over the git history for the static assets #93 Happy to get feedback on it. I am preparing other PRs (with git history) to add the docs, the tests... |
The defined plan is now implemented. I will wait a few more days before closing this one. |
Closing. Thx all. |
This issue is in response to the Notebook v7 JEP.
Today,
nbclassic
depends on thenotebook
package (v6) for its HTML templates, static files, and javascript libraries. Upgrading tonotebook
v7 (i.e. retrolab) would breaknbclassic
.The question remains, what should we do with nbclassic?
There are three directions we could go:
notebook
(v6) package and dropping it's Python tornado server in favor of Jupyter Server.NotebookApp
toServerApp
.notebook<7
and nbclassic cannot be installed next to notebook v7.The text was updated successfully, but these errors were encountered: