Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logo url no longer overrideable #182

Closed
minrk opened this issue Nov 18, 2022 · 1 comment · Fixed by #184
Closed

logo url no longer overrideable #182

minrk opened this issue Nov 18, 2022 · 1 comment · Fixed by #184
Labels
bug Something isn't working

Comments

@minrk
Copy link
Member

minrk commented Nov 18, 2022

The logo URL was previously controlled by default_url, but #168 has hardcoded the value to the nbclassic tree view root. As far as I can tell, it can no longer be overridden, as nbclassic_tree is always defined when running with jupyter_server.

I don't quite follow the discussion in #167 - the logo link is meant to go to the default URL for the server, not the tree root which is only the default default URL, but is meant to be able to be overridden. The tree root in the current view already has a link at the root:

Screenshot 2022-11-18 at 10 21 43

This has been reported as a bug in jupyterhub at jupyterhub/jupyterhub#4220 where the expected behavior of setting default_url no longer has the desired effect.

@minrk minrk added the bug Something isn't working label Nov 18, 2022
@echarles
Copy link
Member

cc/ @mcrutch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants