Make the help for quit_button more generic. #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin-bates
approved these changes
Nov 12, 2020
There was a problem hiding this comment.
These changes look good - thanks Jason.
This strikes me as a remnant from the notebook server where the front-end was "closer". I don't really see anywhere in the server where this information is used (although it is conveyed to the web_app's settings as shutdown_button but that argument is not found in the server's handlers either). Is this something we could/should entertain deprecating?
|
We could deprecate it and put it separately in nbclassic and jlab. I suppose that would be backwards-incompatible, so for 2.0? |
Zsailer
added a commit
to Zsailer/jupyter_server
that referenced
this pull request
Nov 18, 2022
…ice. (jupyter-server#334) * minor logging cleanup * minor logging cleanup * list only healthy kernels * Bump to 0.17.2
hMED22
pushed a commit
to hMED22/jupyter_server
that referenced
this pull request
Jan 23, 2023
Make the help for quit_button more generic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes jupyterlab/jupyterlab#8188