-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation of versioning/branches to main README #163
Conversation
|
What is the impact on the PR merge. E.g. a new feature is developed for next release 0.3.0:
I prefer option 3 for simplicity. |
I fully agree. Features should be developed for master. Release branches should get created with or after the release. When the release is properly tagged, branch creation can be delayed until there's a need for the branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Zach - this will be very helpful. I just had a couple comments.
Thanks, all!
Yes, this is what I intended. I think @kevin-bates inline comment will help clarify this. Master represents the latest minor version. We won't create a branch for the latest version until we release that branch on PyPI. Once we make a release, we bump the version in master and add features there. |
Ok, modified the language to reflect that we're only creating branches once a version is released. Let me know if you think this needs anymore editting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thank you.
* add session expiration handling * cleanup * use host name for cookie * finish extension * cleanup * fix comment * fix comment * update tests
…er#163) * update readme to explain versioning * add detail to versioning docs * clarify language in README on versioning and bump version
Adds language around versioning.
Also bumps master to 0.3.0.dev.