From 6c00c531b5bfbdeb7354ccfcb277461492996aec Mon Sep 17 00:00:00 2001 From: John Emmons Date: Thu, 10 Nov 2016 16:11:25 -0600 Subject: [PATCH] Add links and scope section to make it clear that this proposal is limited to classic notebook and not Jupyter lab --- .../jupyter-notebook-gui-translation.md | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/jupyter-notebook-gui-translation/jupyter-notebook-gui-translation.md b/jupyter-notebook-gui-translation/jupyter-notebook-gui-translation.md index 9913e635..5a604e04 100644 --- a/jupyter-notebook-gui-translation/jupyter-notebook-gui-translation.md +++ b/jupyter-notebook-gui-translation/jupyter-notebook-gui-translation.md @@ -2,7 +2,7 @@ ## Problem -There is currently no standard approach for translating the GUI of Jupyter notebook. +There is currently no standard approach for translating the GUI of [Jupyter notebook]( https://github.com/jupyter/notebook). This has driven some people to do a [single language translation for Jupyter 4.1](https://twitter.com/Mbussonn/status/685870031247400960). @@ -12,6 +12,12 @@ For information: previous attempts and related issues: - https://github.com/ipython/ipython/pull/5922 - https://github.com/jupyter/notebook/issues/870 +## Scope +The proposed enhancement is for "classic" [Jupyter notebook]( https://github.com/jupyter/notebook), +not [Jupyter lab](https://github.com/jupyterlab/jupyterlab). +Hopefully, some of the concepts used here will carry over, but for now the scope here is limited to classic +[Jupyter notebook]( https://github.com/jupyter/notebook). + ## Proposed Enhancement Use [Babel](http://babel.pocoo.org/en/latest/) @@ -30,11 +36,11 @@ code within Jupyter. ## Detailed Explanation -The Jupyter notebook code presents a significant challenge in terms of enablement for translation, +The [Jupyter notebook code]( https://github.com/jupyter/notebook) presents a significant challenge in terms of enablement for translation, mostly because there are multiple different types of source code from which translatable UI strings are derived. -In Jupyter, translatable strings can come from one of three places: +In [Jupyter notebook]( https://github.com/jupyter/notebook), translatable strings can come from one of three places: 1. Directly from Python code