Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install jupyterhub-base and nodejs packages instead of jupyterhub package #2171

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Install jupyterhub-base and nodejs packages instead of jupyterhub package #2171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c91604
Install jupyterhub-base instead of jupyterhub
consideRatio Nov 5, 2024
b739883
Update images/base-notebook/Dockerfile
mathbunnyru Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/using/recipe_code/jupyterhub_version.dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
FROM quay.io/jupyter/base-notebook

RUN mamba install --yes 'jupyterhub==4.0.1' && \
RUN mamba install --yes 'jupyterhub-base==4.0.1' && \
mamba clean --all -f -y && \
fix-permissions "${CONDA_DIR}" && \
fix-permissions "/home/${NB_USER}"
8 changes: 7 additions & 1 deletion images/base-notebook/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,15 @@ USER ${NB_UID}
# files across image layers when the permissions change
WORKDIR /tmp
RUN mamba install --yes \
'jupyterhub' \
'jupyterhub-base' \
'jupyterlab' \
'nbclassic' \
# nodejs has historically been installed indirectly as a dependency.
# When it was no longer getting installed indirectly,
# we started installing it explicitly to avoid introducing a breaking change
# for users building on top of these images.
# See: https://github.com/jupyter/docker-stacks/pull/2171
'nodejs' \
# Sometimes, when the new version of `jupyterlab` is released, latest `notebook` might not support it for some time
# Old versions of `notebook` (<v7) didn't have a restriction on the `jupyterlab` version, and old `notebook` is getting installed
# That's why we have to pin the minimum notebook version
Expand Down
2 changes: 2 additions & 0 deletions tests/docker-stacks-foundation/test_packages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,10 @@
"grpcio-status",
"grpcio",
"hdf5",
"jupyterhub-base",
"jupyterlab-git",
"mamba[version='<2.0.0']",
"nodejs",
"notebook[version='>",
"openssl",
"pandas[version='>",
Expand Down
Loading