-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start using spark4-preview versions #2159
Conversation
I checked the build logs, and the expected version of spark is installed:
Then I checked the image itself, and the directories are named properly:
And finally, the image tag:
So, everything works exactly as expected |
@@ -63,7 +63,7 @@ USER ${NB_UID} | |||
RUN mamba install --yes \ | |||
'grpcio-status' \ | |||
'grpcio' \ | |||
'pandas=2.0.3' \ | |||
'pandas=2.2.2' \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went with 2.2.2
, becuase preview2 supports this version
@@ -1,5 +1,13 @@ | |||
# Changelog | |||
|
|||
## 2024-10-22 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will describe the release schedule in this PR: #2072
@@ -36,7 +36,7 @@ def get_latest_spark_version() -> str: | |||
stable_versions = [ | |||
ref.removeprefix("spark-").removesuffix("/") | |||
for ref in all_refs | |||
if ref.startswith("spark-") and "incubating" not in ref and "preview" not in ref | |||
if ref.startswith("spark-") and "incubating" not in ref |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only line we will have to revert to start using stable versions again (that's why I made a separate commit improving spark setup scripts)
) | ||
warnings = TrackedContainer.get_warnings(logs) | ||
assert len(warnings) == 1 | ||
assert "Using incubator modules: jdk.incubator.vector" in warnings[0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this might disappear when we switch to JDK 21, but that's a separate story and won't be a part of the switch to Python 3.12
Unfortunately, When I run I created an upstream issue: sparklyr/sparklyr#3468 |
Describe your changes
Issue ticket if applicable
Checklist (especially for first-time contributors)