Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Ubuntu 24.04 Image base #2131

Merged
merged 9 commits into from
Aug 30, 2024
Merged

Conversation

jmcgrath207
Copy link
Contributor

@jmcgrath207 jmcgrath207 commented Aug 6, 2024

Describe your changes

  • Upgrade to Ubuntu 24.04

Testing.

Ran DOCKER_BUILD_ARGS='--no-cache make build-all. All images were built successfully.

Build Logs ( too big to paste)
https://gist.github.com/jmcgrath207/cf77b5b52cb5c10d45e667ec1052db60

@benz0li
Copy link
Contributor

benz0li commented Aug 7, 2024

Makefile Show resolved Hide resolved
.readthedocs.yaml Outdated Show resolved Hide resolved
@jmcgrath207
Copy link
Contributor Author

Thanks for the review @mathbunnyru. I have fixed up my PR.

@mathbunnyru
Copy link
Member

Thanks.

  1. Waiting for a separate PR for ROOT_CONTAINER bug as well.
  2. This PR is currently waiting for the first point Ubuntu release per our policy. It should only take 3 days

@jmcgrath207
Copy link
Contributor Author

@mathbunnyru ah, the comment didn't go through.

Here is the root container arg PR.
#2133

@mathbunnyru
Copy link
Member

And one more thing - you need to update Using old images table in the root README.md file

@mathbunnyru
Copy link
Member

Ubuntu 24.04.1 LTS should be released on August 29, 2024

I think this PR is ready to be merged and when this is merged, I will update the README with the latest 22.04 build.

@benz0li could you please take a look here, does it look ok?

@benz0li
Copy link
Contributor

benz0li commented Aug 27, 2024

@benz0li could you please take a look here, does it look ok?

Yes, LGTM.

@benz0li
Copy link
Contributor

benz0li commented Aug 27, 2024

Since b-data's/my GPU accelerated JuypterLab docker stacks are derived from nvidia/cuda, it will be a while before ubuntu:24.04-based images available.

Cross reference: https://gitlab.com/nvidia/container-images/cuda/-/issues/226#note_1930113698

@consideRatio
Copy link
Collaborator

Thank you everyone for your work!! Super happy about these images are available and gets maintained so well!

@mathbunnyru
Copy link
Member

Ubuntu 24.04.1 LTS is now available

https://ubuntu.com/blog/upgrade-your-desktop-ubuntu-24-04-lts

@mathbunnyru mathbunnyru merged commit e51895b into jupyter:main Aug 30, 2024
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants