From c2d9d1f06a35d56ffe84d2360fb562b8b3bf5165 Mon Sep 17 00:00:00 2001
From: Ayaz Salikhov <mathbunnyru@users.noreply.github.com>
Date: Mon, 4 Nov 2024 14:55:35 +0000
Subject: [PATCH] Pin min notebook version (#2167)

* [TMP] Pin min notebook version

* Update Dockerfile
---
 images/base-notebook/Dockerfile                 | 6 +++++-
 tests/docker-stacks-foundation/test_packages.py | 1 +
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/images/base-notebook/Dockerfile b/images/base-notebook/Dockerfile
index 0cde5b5d9..dd068c809 100644
--- a/images/base-notebook/Dockerfile
+++ b/images/base-notebook/Dockerfile
@@ -42,7 +42,11 @@ RUN mamba install --yes \
     'jupyterhub' \
     'jupyterlab' \
     'nbclassic' \
-    'notebook' && \
+    # Sometimes, when the new version of `jupyterlab` is released, latest `notebook` might not support it for some time
+    # Old versions of `notebook` (<v7) didn't have a restriction on the `jupyterlab` version, and old `notebook` is getting installed
+    # That's why we have to pin the minimum notebook version
+    # More info: https://github.com/jupyter/docker-stacks/pull/2167
+    'notebook>=7.2.2' && \
     jupyter server --generate-config && \
     mamba clean --all -f -y && \
     npm cache clean --force && \
diff --git a/tests/docker-stacks-foundation/test_packages.py b/tests/docker-stacks-foundation/test_packages.py
index 9b70be38c..0508ff140 100644
--- a/tests/docker-stacks-foundation/test_packages.py
+++ b/tests/docker-stacks-foundation/test_packages.py
@@ -76,6 +76,7 @@
     "hdf5",
     "jupyterlab-git",
     "mamba[version='<2.0.0']",
+    "notebook[version='>",
     "openssl",
     "pandas[version='>",
     "protobuf",