Skip to content
This repository has been archived by the owner on Sep 1, 2022. It is now read-only.

Remove the name urth from all our elements and apis #187

Open
1 of 4 tasks
lbustelo opened this issue Jan 21, 2016 · 11 comments
Open
1 of 4 tasks

Remove the name urth from all our elements and apis #187

lbustelo opened this issue Jan 21, 2016 · 11 comments

Comments

@lbustelo
Copy link
Collaborator

lbustelo commented Jan 21, 2016

The goal of this issue is to get rid of the urth name from anything that is accessible by the end user. A couple of items include

  • Rename all elements to change <urth-core-*> or <urth.viz.*> to <jupyter-*>. For example:
    <urth-core-function> -> <jupyter-function>
  • Rename urth.widgets.* to jupyter_declwidgets.* (open for suggestions) in python and scala
  • Deprecate the UrthData and Urth globals
  • Rename urth_components directory used in the link tag href
@lbustelo lbustelo added this to the 0.4.0 milestone Jan 21, 2016
@lbustelo
Copy link
Collaborator Author

Refs #141

@parente
Copy link
Member

parente commented Jan 21, 2016

Rename urth.widgets.* to jupyter_declwidgets.* (open for suggestions) in python and scala

Just curious, would it be possible to still alias jupyter_declwidgets with urth.widgets just so that all the notebooks in existence continue to work? We don't necessarily have to because it's all < 1.0 and incubator, but would be nice if it's not a huge pain to maintain such an alias.

@lbustelo
Copy link
Collaborator Author

Not sure if that is possible, but I we would certainly look into it.

As a note, we should do the same for the Python and scala libraries.

@lbustelo
Copy link
Collaborator Author

Some work for this is being done in #315

@lbustelo lbustelo modified the milestones: 0.6.0, 0.4.0 Apr 28, 2016
@lbustelo lbustelo modified the milestones: 0.7.0, 0.6.0 May 17, 2016
@lbustelo
Copy link
Collaborator Author

lbustelo commented Jun 9, 2016

The rename of the kernel APIs is being done in #389

@parente
Copy link
Member

parente commented Jun 15, 2016

Is urth_components going to change too?

@lbustelo
Copy link
Collaborator Author

It probably should... to what?

@aluu317
Copy link
Collaborator

aluu317 commented Aug 25, 2016

After talking to @lbustelo yesterday, he suggested that we find a way to make the transition from urth-* to jupyter-* by first supporting both namings so it's backwards compatible for the current demo/example notebooks.

I was hoping we could do this by using Polymer inheritance support. Unfortunately, Polymer 1.0 only supports extending native html elements, as opposed to extending custom elements (looks like they're working on it for future release): https://www.polymer-project.org/1.0/docs/devguide/registering-elements#type-extension

@lbustelo lbustelo removed this from the 0.7.0 milestone Sep 20, 2016
@lbustelo
Copy link
Collaborator Author

Removing this from the milestone. Renaming the elements at this point does not buy us anything other than more pain. There is no easy way of doing it other than copy/paste.

@haobibo
Copy link
Contributor

haobibo commented Nov 14, 2016

How about create two folders in elements: jupyter-core and jupyter-viz? We can keep the urth-* and make them depreciated in this version (0.x.x), and abandon them in next major version (say 1.x.x).

The current organization of the urth- components are in a flat style, I wonder if we can we put all urth-core-* into jupyter-core, and put all urth-viz-* into jupyter-viz, because visualizations like line, pie, bar, etc. are quite similar to each other and use the same library (nvd3). Typically, users may want to develop some other viz elements using third party JS libraries like highcharts, eCharts, etc. For each library, it supports many types of charts. I wonder if it's better to put such similar components into same folder.

@lbustelo
Copy link
Collaborator Author

@haobibo So the main headache was that we could not find a way to create aliases in Polymer without basically having to copy code.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants